fix: servient.shutdown does not close open http connections - #1548
Open
DhairyaMajmudar wants to merge 1 commit into
Open
fix: servient.shutdown does not close open http connections#1548DhairyaMajmudar wants to merge 1 commit into
DhairyaMajmudar wants to merge 1 commit into
Conversation
Signed-off-by: DhairyaMajmudar <dhairya.opensource@gmail.com>
DhairyaMajmudar
requested review from
danielpeintner and
relu91
as code owners
August 16, 2026 05:28
| public readonly scheme: string = "http"; | ||
| private config: HttpConfig | null = null; | ||
| private oAuthManager: OAuthManager = new OAuthManager(); | ||
| private readonly clients = new Set<ProtocolClient>(); |
Member
There was a problem hiding this comment.
I have a question about why using Set instead of an array. I wonder whether it can happen that a HttpClient may be treated as duplicate... hence creating for example 2 HttpClient instances but having just one entry in the set...
Author
There was a problem hiding this comment.
@danielpeintner , I used a Set to avoid accidentally tracking the same instance more than once, but I’m happy to use an array for consistency with MqttClientFactory if you prefer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Servient.shutdown()did not close active HTTP property observations. Although shutdown completed, long-polling or SSE connections could remain open and prevent the Node process from exiting.The reason for this was that HTTP and HTTPS client factories did not retain the clients they created, and their
destroy()methods did not stop those clients.References
Closes: #1506
Related to: #1503 (comment)
cc: @relu91 @egekorkan